Skip to content

[SDK] Optimize multi-event querying with indexer #6822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2025
Merged

[SDK] Optimize multi-event querying with indexer #6822

merged 4 commits into from
Apr 23, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 23, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving the efficiency of multi-event querying in the thirdweb library, enhancing error handling in the paymaster, and refining NFT ownership checks.

Detailed summary

  • Improved multi-event querying with useIndexer option in watch-events.ts.
  • Enhanced error handling in paymaster.ts for clearer error messages.
  • Added ownership checks in NFT tests to ensure correct owner verification.
  • Updated owner address formatting for consistency in getNFT.test.ts.
  • Refactored NFT transformation logic to handle owner_addresses more efficiently in get-nfts.ts.
  • Improved event data handling and sorting in get-events.ts.
  • Cleaned up useActivity hook for better performance and readability in useActivity.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:30pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:30pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:30pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:30pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 8:30pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 4720458

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review April 23, 2025 08:44
@joaquim-verges joaquim-verges requested review from a team as code owners April 23, 2025 08:44
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK labels Apr 23, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Apr 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51 KB (+0.16% 🔺) 1.1 s (+0.16% 🔺) 227 ms (+110.87% 🔺) 1.3 s
thirdweb (cjs) 143.73 KB (-0.01% 🔽) 2.9 s (-0.01% 🔽) 426 ms (+58.53% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.66 KB (0%) 114 ms (0%) 66 ms (+892.55% 🔺) 179 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 35 ms (+890.63% 🔺) 45 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 124 ms (+656.55% 🔺) 511 ms

@codecov
Copy link

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.21%. Comparing base (683e3b0) to head (be3dcd3).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/event/actions/get-events.ts 94.28% 1 Missing and 1 partial ⚠️
...ackages/thirdweb/src/event/actions/watch-events.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6822      +/-   ##
==========================================
+ Coverage   55.18%   55.21%   +0.02%     
==========================================
  Files         896      896              
  Lines       56951    56987      +36     
  Branches     3946     3952       +6     
==========================================
+ Hits        31430    31465      +35     
  Misses      25425    25425              
- Partials       96       97       +1
Flag Coverage Δ
packages 55.21% <91.66%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
...ackages/thirdweb/src/event/actions/watch-events.ts 14.28% <0.00%> (-0.53%) ⬇️
packages/thirdweb/src/event/actions/get-events.ts 85.20% <94.28%> (+0.64%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

graphite-app[bot]
graphite-app bot reviewed Apr 23, 2025
View reviewed changes
@joaquim-verges joaquim-verges force-pushed the _SDK_Optimize_multi-event_querying_with_indexer branch from 2d67333 to 697d417 Compare April 23, 2025 09:06
@joaquim-verges joaquim-verges force-pushed the _SDK_Optimize_multi-event_querying_with_indexer branch 2 times, most recently from f6a287e to ffc2726 Compare April 23, 2025 09:19
@joaquim-verges joaquim-verges force-pushed the _SDK_Optimize_multi-event_querying_with_indexer branch from ffc2726 to 3c5b298 Compare April 23, 2025 09:23
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground April 23, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 April 23, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui April 23, 2025 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – login April 23, 2025 18:42 Inactive
@joaquim-verges joaquim-verges force-pushed the _SDK_Optimize_multi-event_querying_with_indexer branch from 65daec3 to d3de8db Compare April 23, 2025 19:55
@joaquim-verges joaquim-verges force-pushed the _SDK_Optimize_multi-event_querying_with_indexer branch from d3de8db to 4720458 Compare April 23, 2025 20:23
@joaquim-verges joaquim-verges merged commit 33666aa into main Apr 23, 2025
20 of 21 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_Optimize_multi-event_querying_with_indexer branch April 23, 2025 23:36
@joaquim-verges joaquim-verges mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls left review comments

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

@joaquim-verges joaquim-verges

Labels

Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @jnsdls